ENH: Give more informative file format errors #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
commented
Feb 14, 2024
| @@ -491,7 +494,7 @@ def _format_from_contents(self) -> FileFormat: | |||
| self.file.seek(mark) | |||
| else: | |||
| if not self.exists(): | |||
| raise ValueError(f"File {self.name} does not exist") | |||
| raise FileNotFoundError(f"File {self.name} does not exist") | |||
There was a problem hiding this comment.
Bonus exception type change
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 80.08% 80.06% -0.02%
==========================================
Files 97 97
Lines 13612 13634 +22
Branches 2186 2187 +1
==========================================
+ Hits 10901 10916 +15
- Misses 1981 1988 +7
Partials 730 730 ☔ View full report in Codecov by Sentry. |
mferrera
force-pushed
the
improve-data-reader-error
branch
from
0773769 to
844e3c6
Compare
jcrivenaes
reviewed
Feb 14, 2024
jcrivenaes
reviewed
Feb 14, 2024
jcrivenaes
approved these changes
Feb 14, 2024
mferrera
force-pushed
the
improve-data-reader-error
branch
from
844e3c6 to
335dbff
Compare
This will list some potential file formats, which are not complete in their file extensions permutations but should be sufficient enough to give a hint as to what kind of required.
mferrera
force-pushed
the
improve-data-reader-error
branch
from
335dbff to
b51d79e
Compare
mferrera
commented
Feb 14, 2024
Comment on lines
+55
to
+64
| [ | ||
| FileFormat.ROFF_BINARY, | ||
| FileFormat.ROFF_ASCII, | ||
| FileFormat.EGRID, | ||
| FileFormat.FEGRID, | ||
| FileFormat.GRDECL, | ||
| FileFormat.BGRDECL, | ||
| FileFormat.XTG, | ||
| FileFormat.HDF, | ||
| ] |
There was a problem hiding this comment.
Ideally in #1164 this list becomes a property of the different class types, or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #706
This will list some potential file formats, which are not complete in their file extensions permutations but should be sufficient enough to give a hint as to what kind of required.